Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URDF Sim Tutorial #3952

Merged
merged 9 commits into from
Dec 12, 2024
Merged

URDF Sim Tutorial #3952

merged 9 commits into from
Dec 12, 2024

Conversation

DLu
Copy link
Contributor

@DLu DLu commented Oct 5, 2023

See the code conversion here: ros/urdf_sim_tutorial#13

Currently in the process of getting the packages on the buildfarm: ros/rosdistro#38713

This PR is for Humble, because I don't believe its compatible with Gazebo New Coke.

@DLu DLu requested review from clalancette and audrow as code owners October 5, 2023 18:08
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is for Humble, because I don't believe its compatible with Gazebo New Coke.

As of right now, I don't believe there is a difference between Rolling and Humble in this regards. That is, they share the same underlying Ubuntu 22.04, so the same Gazebo stuff should work on both (this also goes for Iron). But I could be wrong, maybe @ahcorde can comment more on this.

DLu added 2 commits July 30, 2024 10:39
Signed-off-by: David V. Lu!! <davidvlu@gmail.com>
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next review pass.

DLu and others added 2 commits July 31, 2024 16:14
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: David V. Lu!! <davidvlu@gmail.com>
@DLu DLu requested a review from clalancette August 12, 2024 15:22
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more minor changes, then I'm happy with this! Thanks for the continued iteration.

DLu and others added 2 commits October 21, 2024 23:08
Co-authored-by: Chris Lalancette <clalancette@gmail.com>
Signed-off-by: David V. Lu!! <davidvlu@gmail.com>
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@clalancette do you mind to review this again ?

@ahcorde ahcorde requested a review from clalancette October 25, 2024 09:45
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of things inline.

However, I'm now mostly concerned by the fact that this tutorial requires Gazebo Classic. Support for that is ending in January 2025, and so adding this tutorial now (even to Humble) seems like something of a mistake: https://classic.gazebosim.org/ . Is there a way to update this tutorial to use Ignition Fortress instead?

Pinging @azeey for thoughts as well.



Based on `this ROS 1 tutorial <http://wiki.ros.org/urdf/Tutorials/Using%20a%20URDF%20in%20Gazebo>`_.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Prerequisites
-------------


Nonfunctional Gazebo Interface
------------------------------
We can spawn the model we already created into Gazebo using ``gazebo.launch.py``
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this, I find this statement confusing. Who created this model? Is this tutorial following off of another one? If that's the case, the fact that we require a previous tutorial should be marked in the prerequisites.

@ros-discourse
Copy link

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/missing-documentation-for-sensors/40858/13

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After talking about this with @azeey , this should be OK even though it is with old Gazebo. Hopefully we can update this to new Gazebo for Rolling.

@clalancette clalancette merged commit ce912f6 into ros2:humble Dec 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants